ext/pdo_sqlite: EXPLAIN mode support for SQL statements. #18829
Closed
+505
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
available since 3.41.0 we can reprepare a statement in either explain, explain query plan or the usual prepared mode.
devnexen
force-pushed
the
pdo_sqlite3_explaintome
branch
2 times, most recently
from
224a680 to
466ddc8
Compare
SakiTakamachi
approved these changes
Jun 13, 2025
nielsdos
reviewed
Jun 13, 2025
| return 0; | ||
| } | ||
| if (Z_LVAL_P(zval) < 0 || Z_LVAL_P(zval) > 2) { | ||
| zend_value_error("explain mode must be one of the EXPLAIN_MODE_* constants"); |
There was a problem hiding this comment.
For class constants we normally prefix the class name, i.e. Pdo\Sqlite::EXPLAIN_MODE_* constants
|
@devnexen It seems this test can fail, presumably due to differences in output in different versions of sqlite. Can we adjust the tested output while preserving the coverage of this test? |
|
Ok will do in my pdo sqlite PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
available since 3.41.0 we can reprepare a statement in either
explain, explain query plan or the usual prepared mode.